Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deadlock when handling multiple stream entries errors #576

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

merlimat
Copy link
Collaborator

This is an alternate approach for #572

The closeCh is used to propagate back the error to the client stream handler. Writing on this channel should never block and it's just necessary to write once, all other errors are just ignored.

@merlimat merlimat merged commit e7ef873 into streamnative:main Nov 16, 2024
3 of 4 checks passed
@merlimat merlimat deleted the fix-deadlock-stream-error branch November 16, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants